SOLR-15409: Upgrade to Zookeeper 3.7.0#130
Merged
madrob merged 1 commit intoapache:mainfrom May 18, 2021
Merged
Conversation
janhoy
approved these changes
May 18, 2021
Contributor
janhoy
left a comment
janhoy
left a comment
There was a problem hiding this comment.
LGTM. Finally get rid of commons-lang-2 as well.
dsmiley
reviewed
May 18, 2021
|
|
||
| import org.apache.commons.lang.StringUtils; | ||
| import org.apache.solr.client.solrj.SolrServerException; | ||
| import org.apache.solr.common.StringUtils; |
Contributor
There was a problem hiding this comment.
Was the removal of the commons-lang 2.6 dependency tied only to this file or was the older ZooKeeper using it? If it was only this file, the PR should have been split. And FYI Solr depends on Commons-Lang-3 so StringUtils is there as well and has these methods.
Contributor
Author
|
Our dep on commons-lang 2 was through Zookeeper. When I updated to ZK 3.7.0, the transitive dependency went away. I tried to look for replacements but didn't see anything. |
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.