SOLR-16531: Disable unused Jersey features#1335
Merged
gerlowskija merged 3 commits intoapache:mainfrom Feb 6, 2023
Merged
Conversation
These features incur a small cost at application startup time, so disabling them helps keep our use of Jersey lean.
Contributor
Author
|
This PR consists mainly of a snippet that I've had in a variety of other Jersey-related PRs, and that has been previously reviewed. Pulling it into its own PR here, so that it's better documented in the git-log, can be reverted or cherry-picked independently, etc. |
epugh
approved these changes
Feb 4, 2023
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
LGTM. I googled to learn more about these, and found this doc that listed some of them (and a bunch more) https://eclipse-ee4j.github.io/jersey.github.io/documentation/2.29/appendix-properties.html
risdenk
approved these changes
Feb 4, 2023
madrob
reviewed
Feb 4, 2023
solr/core/src/java/org/apache/solr/jersey/JerseyApplications.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Alright, thanks for the reviews guys. Aiming to merge this later today. |
gerlowskija
added a commit
that referenced
this pull request
Feb 6, 2023
These features incur a small cost at application startup time, so disabling them helps keep our use of Jersey lean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16531
Description
Jersey has several optional features that we don't need or use. Disabling these keeps our use of Jersey as lightweight as possible.
Solution
These features are disabled by setting particular configuration props in each Jersey 'application' that gets created.
Tests
Manually tested via log-message inspection. Manual validation of the improved Jersey app-startup performance. Existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.