SOLR-15418: V2 API: Fix GET to /select and others#134
Merged
dsmiley merged 3 commits intoapache:mainfrom May 24, 2021
Merged
Conversation
Indirectly fixed by not adding ContentStreams that are empty.
Contributor
Author
|
I tried to avoid the PushBackInputStream thing but in the end I found it necessary. At least it will rarely be used, I think. I did ensure this code actually works by temporarily removing the short-circuit conditions and then running the test. FYI this is called by StandardRequestParsers.parseParamsAndFillStreams. I don't like the way that method makes assumptions about paths for /schema and v2 API which seem to be concerns that should be elsewhere like HttpSolrCall (if necessary) or perhaps give handlers the opportunity to get involved in this (if necessary). |
madrob
pushed a commit
to madrob/solr
that referenced
this pull request
May 25, 2021
Indirectly fixed by not adding ContentStreams that are empty.
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
Indirectly fixed by not adding ContentStreams that are empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indirectly fixed by not adding ContentStreams that are empty.
https://issues.apache.org/jira/browse/SOLR-15418