Merged
Conversation
risdenk
force-pushed
the
SOLR-16732-misc-sonar-fixes
branch
from
0bb3656 to
56e3de6
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java
Outdated
Show resolved
Hide resolved
risdenk
force-pushed
the
SOLR-16732-misc-sonar-fixes
branch
2 times, most recently
from
d1014a4 to
0437060
Compare
risdenk
force-pushed
the
SOLR-16732-misc-sonar-fixes
branch
from
0437060 to
ca6a2b7
Compare
risdenk
requested review from
HoustonPutman,
colvinco,
dsmiley,
elyograg,
epugh,
gerlowskija,
janhoy,
justinrsweeney,
magibney and
mkhludnev
dsmiley
approved these changes
Apr 2, 2023
risdenk
added a commit
that referenced
this pull request
Apr 3, 2023
* Replace String non regex replaceAll with replace
* indexOf to contains or single character indexOf
* Remove NBSP in log message
* unindented if statements missing {}
* Use && instead of & for boolean comparisons
* Replace .equals with isEmpty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16732