SOLR-15446: Fix three off-by-one ArrayList initialCapacity choices when calling ZooKeeper.multi API.#156
Merged
risdenk merged 3 commits intoapache:mainfrom Mar 24, 2023
Merged
Conversation
…en calling ZooKeeper.multi API.
Contributor
|
Not directly related to the PR, but is there a reason for using ZooKeeper.multi when only issuing 1 command? |
Contributor
Author
Interesting question! From a quick look at the ZooKeeper docs I could see no reasons for preferring |
risdenk
approved these changes
Oct 27, 2022
Contributor
|
looks like this just needs to be brought up to main |
Contributor
|
Another idea might be |
Contributor
|
FWIW PR #1232 addressed a part of this. I'll resolve the conflict and use List.of since that makes it so we don't even need to deal w/ sizes. |
risdenk
approved these changes
Jan 10, 2023
risdenk
added a commit
that referenced
this pull request
Mar 24, 2023
…en calling ZooKeeper.multi API. (#156) Co-authored-by: Kevin Risden <krisden@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15446 created but no
solr/CHANGES.txtentry planned for this small change.