Skip to content

Comments

Fix filename in external-files-processes.adoc#1574

Merged
HoustonPutman merged 1 commit intoapache:mainfrom
Codearella:patch-1
Apr 18, 2023
Merged

Fix filename in external-files-processes.adoc#1574
HoustonPutman merged 1 commit intoapache:mainfrom
Codearella:patch-1

Conversation

@Codearella
Copy link
Contributor

I don't think these were supposed to have an underscore at the end - it appears to be a typo. (external_fieldname_ should be external_fieldname)

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

I don't think these were supposed to have an underscore at the end - it appears to be a typo. (external_fieldname_ should be external_fieldname)
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the code and this looks correct!

Thanks for finding and fixing this 🙂

@HoustonPutman HoustonPutman changed the title Update external-files-processes.adoc Fix filename in external-files-processes.adoc Apr 18, 2023
@HoustonPutman HoustonPutman merged commit 89adb07 into apache:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants