SOLR-16755: bin/solr's '-noprompt' option no longer works for examples#1576
Merged
janhoy merged 5 commits intoapache:mainfrom Apr 19, 2023
Merged
SOLR-16755: bin/solr's '-noprompt' option no longer works for examples#1576janhoy merged 5 commits intoapache:mainfrom
janhoy merged 5 commits intoapache:mainfrom
Conversation
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Contributor
|
@janhoy used bash arrays instead of the string. We should also do this with |
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Contributor
Author
|
Thanks Houston. I removed the now obsolete shellcheck disable comment. Will commit and backport shortly |
epugh
reviewed
Apr 19, 2023
epugh
requested changes
Apr 19, 2023
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
LGTM once two echos stripped out ;-)
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
janhoy
added a commit
that referenced
this pull request
Apr 19, 2023
#1576) Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com> Co-authored-by: Houston Putman <houston@apache.org>
janhoy
added a commit
that referenced
this pull request
Apr 19, 2023
#1576) Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com> Co-authored-by: Houston Putman <houston@apache.org> Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16755
The new test fails with
# ERROR: No line foundwithout this patch.