Skip to content

SOLR-16761: Document the bin/solr api command#1581

Merged
epugh merged 4 commits intoapache:mainfrom
epugh:SOLR-16761
Apr 24, 2023
Merged

SOLR-16761: Document the bin/solr api command#1581
epugh merged 4 commits intoapache:mainfrom
epugh:SOLR-16761

Conversation

@epugh
Copy link
Contributor

@epugh epugh commented Apr 22, 2023

https://issues.apache.org/jira/browse/SOLR-16761

Description

I didn't know it existed..

Solution

Bit o' docs.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh
Copy link
Contributor Author

epugh commented Apr 22, 2023

As I opened this PR I wondered to myself, why do we have this command? Why not just use Curl etc? I'm curious if we have any ideas why this is here? For situations where you don't have curl???

@HoustonPutman
Copy link
Contributor

As I opened this PR I wondered to myself, why do we have this command? Why not just use Curl etc? I'm curious if we have any ideas why this is here? For situations where you don't have curl???

There are a couple issues, like basicAuth and TLS I believe, that this makes much easier. (Though I have seen the command take extraordinary amounts of time to run. Like 5 seconds for a basic check that should take milliseconds)

Comment on lines +77 to +78
=== Improvements to Solr CLI
* the bin/solr -i and bin/solr -info removed in favour of bin/solr status command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Improvements to Solr CLI
* the bin/solr -i and bin/solr -info removed in favour of bin/solr status command.
=== Improvements to the Solr CLI
* The`-i` and `-info` options for `bin/solr` have been removed in favour of the `bin/solr status` command.

I think you added this to the wrong PR though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh.... How about I must merge this one ;-)

@epugh epugh merged commit b827f11 into apache:main Apr 24, 2023
epugh added a commit that referenced this pull request Apr 24, 2023
* add section for 9.3 that will be longer as more solrcli changes show up

* give the user a hint why they use this instead of tools like curl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments