SOLR-16678 Collection API v2 CREATE does not handle user-defined properties#1663
Merged
gerlowskija merged 2 commits intoapache:mainfrom May 26, 2023
Merged
SOLR-16678 Collection API v2 CREATE does not handle user-defined properties#1663gerlowskija merged 2 commits intoapache:mainfrom
gerlowskija merged 2 commits intoapache:mainfrom
Conversation
…erties test showing updated syntax
Member
Author
|
I don't see how the failures are related to this PR. I only introduced an extra test |
Contributor
|
They are likely unrelated. You can look here for tests that fail "often": http://fucit.org/solr-jenkins-reports/failure-report.html |
gerlowskija
approved these changes
May 26, 2023
Contributor
gerlowskija
left a comment
There was a problem hiding this comment.
LGTM, thanks for the test Alex. Gonna aim to merge later today.
Contributor
|
(Tests pass for me locally - the Crave failures appear to be known flaky tests, so I'm going to proceed with merging.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16678
Description
SOLR-16678 is not a bug, it's using outdated syntax. Adding a test to showcase this, because I could not find an already exiting one.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.