Skip to content

SOLR-16839: Fix spread-domain bug in AffinityPlacementFactory#1696

Merged
tflobbe merged 1 commit intoapache:mainfrom
tflobbe:spread-domain-bug
Jun 8, 2023
Merged

SOLR-16839: Fix spread-domain bug in AffinityPlacementFactory#1696
tflobbe merged 1 commit intoapache:mainfrom
tflobbe:spread-domain-bug

Conversation

@tflobbe
Copy link
Copy Markdown
Member

@tflobbe tflobbe commented Jun 7, 2023

This commit fixes a bug where AffinityPlacementFactory would fail to compute placements for shards where one or more replicas are located in down nodes.

The feature hasn't been released yet, so this isn't affecting any official version

This commit fixes a bug where AffinityPlacementFactory would fail to compute placements for shards where one or more replicas are located in down nodes
@tflobbe tflobbe requested a review from HoustonPutman June 7, 2023 22:40
Copy link
Copy Markdown
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tflobbe tflobbe merged commit 8089e6f into apache:main Jun 8, 2023
@tflobbe tflobbe deleted the spread-domain-bug branch June 8, 2023 18:52
tflobbe added a commit that referenced this pull request Jun 8, 2023
This commit fixes a bug where AffinityPlacementFactory would fail to compute placements for shards where one or more replicas are located in down nodes
@mkhludnev
Copy link
Copy Markdown
Member

Thanks, @tflobbe. May I ask you whether it may affect #1690?

@tflobbe
Copy link
Copy Markdown
Member Author

tflobbe commented Jun 9, 2023

May I ask you whether it may affect #1690?

Just put a message there. You'll need to rebase before merging, but the conflicts should be easy to resolve (if auto-merge doesn't do it for you). That said, I'd take a look at #1650 too, since thee will be more conflicts with it

epugh pushed a commit that referenced this pull request Jun 21, 2023
This commit fixes a bug where AffinityPlacementFactory would fail to compute placements for shards where one or more replicas are located in down nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants