SOLR-16825: Migrate api definitions to submodule, pt 3#1902
Merged
gerlowskija merged 7 commits intoapache:mainfrom Sep 11, 2023
Merged
SOLR-16825: Migrate api definitions to submodule, pt 3#1902gerlowskija merged 7 commits intoapache:mainfrom
gerlowskija merged 7 commits intoapache:mainfrom
Conversation
epugh
approved these changes
Sep 7, 2023
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
I really hope that you had a code refactoring tool for this?!
gerlowskija
added a commit
that referenced
this pull request
Sep 11, 2023
This commit covers the rename-collection, get-public-key, sync-shard, balance- replicas, force-leader, and replace-node APIs. Extracting annotated interfaces for these APIs includes them in the SolrRequest- generation we now do in SolrJ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16825
Description
SOLR-16825 added a new gradle module, 'api', which holds v2 API definitions as interfaces. This allows us to generate an OAS (and SolrRequest implementations from that) as a part of the solrj build.
But these artifacts (the OAS and generated Java code), only cover the v2 APIs that have interfaces in the 'api' module. We need to extract interfaces to live in 'api' for each v2 API in 'core' that doesn't already have one.
Solution
This PR creates 'api' interfaces for a number of v2 APIs, allowing SolrRequest implementations to be generated for them. The following APIs are covered in this PR:
Tests
PR is a refactor, so doesn't add any additional tests. But manual testing has been done to make sure the affected v2 APIs continue to work, and existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.