SOLR-16931: ReRankScaler explain breaks with debug=true and in distributed mode#1936
Merged
Merged
Conversation
…uld also work with debug=query
joel-bernstein
added a commit
to joel-bernstein/solr
that referenced
this pull request
Sep 19, 2023
7 tasks
joel-bernstein
added a commit
that referenced
this pull request
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16931
Description
The ReRankScaler collects specific information for the explain when debugQuery is set to true. But the parameter debug=true doesn't trigger the collection of this data which causes an NPE in the explain.
The work around is to always use debugQuery=true until this ticket is resolved and released.
It turned out that this ticket had two problems. The first one is described above. The second issue is that distributed explain is broken with the ReRankScaler.
The reason for this is that in order to do proper explain for minMaxScaling you need to know the min and max score in the result set. This piece of state is maintained in the ReRankScaler itself which is inside of the ReRankQuery. But for this information to be populated the query must first be run. In distributed mode, explain is called in the second pass when the ids query is run so the state needed for the explain is not populated. The PR attached to this addresses this problem by doing a single pass distributed query if debugQuery is turned on and if reRank score scaling is applied. I'll add a distributed test for this as well.
This change is very limited in scope because the single pass distributed is only switched on in the very specific case when debugQuery=true and reRankScaling is on.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.