SOLR-17034: Hitting /solr// ends up with HttpSolrCall NPE#2020
Merged
risdenk merged 1 commit intoapache:mainfrom Oct 23, 2023
Merged
SOLR-17034: Hitting /solr// ends up with HttpSolrCall NPE#2020risdenk merged 1 commit intoapache:mainfrom
risdenk merged 1 commit intoapache:mainfrom
Conversation
risdenk
requested review from
HoustonPutman,
dsmiley,
gerlowskija and
magibney
dsmiley
approved these changes
Oct 17, 2023
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
I assume you tested manually. A trivial test somewhere would be nice. Could use LogListener to detect the NPE then lack of it after fix.
Contributor
Author
|
Yea I looked at adding a test for this but couldn't find a good place. I think its pretty obvious that so there is obviously a need for this check in normal cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17034