Skip to content

SOLR-17026: Fix releaseBuild without signing #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HoustonPutman merged 1 commit into from
Oct 31, 2023
Merged

SOLR-17026: Fix releaseBuild without signing #2051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-tools/scripts/buildAndPushRelease.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def prepare(root, version, pause_before_sign, mf_username, gpg_key_id, gpg_passw
if dev_mode:
cmd += ' -Pvalidation.git.failOnModified=false'
if gpg_key_id is None:
cmd += ' -Psign=false -x signJarsPublication' # Disable signing if no key provided to script
cmd += ' -Psign=false' # Disable signing if no key provided to script
else:
cmd += ' -Psign --max-workers 2'
if sign_gradle:
Expand Down
2 changes: 1 addition & 1 deletion gradle/maven/defaults-maven.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ configure(subprojects.findAll { it.path in rootProject.published }) { prj ->
if (project(":solr:distribution").ext.useGpgForSigning) {
useGpgCmd()
}
required { !version.endsWith("SNAPSHOT") }
required { project(":solr:distribution").ext.withSignedArtifacts }
sign publishing.publications.jars
}
}
Expand Down