Skip to content

SOLR-16865 : Solr should warn about low disk space upon startup #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
culmat wants to merge 4 commits into from
Closed

SOLR-16865 : Solr should warn about low disk space upon startup #2080

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49ad8b4
SOLR-16865 : Solr should warn about low disk space upon startup
culmat Nov 15, 2023
6bfa04f
FIX float precision warnings
culmat Nov 23, 2023
a953748
Merge branch 'apache:main' into SOLR-16865
culmat Dec 1, 2023
4f525ba
Merge branch 'main' into SOLR-16865
gerlowskija Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions solr/core/src/java/org/apache/solr/core/CoreContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import com.google.common.annotations.VisibleForTesting;
import io.opentelemetry.api.trace.Tracer;
import jakarta.inject.Singleton;
import java.io.File;
import java.io.IOException;
import java.lang.invoke.MethodHandles;
import java.nio.file.Path;
Expand Down Expand Up @@ -166,6 +167,7 @@
public class CoreContainer {

private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static final float USABLE_DISK_SPACE_PERCENTAGE_THRESHOLD = 2f;

{
// Declared up top to ensure this is present before anything else.
Expand Down Expand Up @@ -1700,6 +1702,16 @@ private SolrCore createFromDescriptor(
}

ConfigSet coreConfig = coreConfigService.loadConfigSet(dcore);
if (log.isWarnEnabled()) {
final Path dataDir = Paths.get(coreConfig.getSolrConfig().getDataDir());
float usableDiskSpacePercentage = getUsableDiskSpacePercentage(dataDir);
if (usableDiskSpacePercentage < USABLE_DISK_SPACE_PERCENTAGE_THRESHOLD) {
log.warn(
"Only {} percent of disk space usable in data directory {}",
usableDiskSpacePercentage,
dataDir);
}
}
dcore.setConfigSetTrusted(coreConfig.isTrusted());
if (log.isInfoEnabled()) {
log.info(
Expand Down Expand Up @@ -1760,6 +1772,11 @@ private SolrCore createFromDescriptor(
}
}

private float getUsableDiskSpacePercentage(Path directory) {
File file = directory.toFile();
return (float) file.getUsableSpace() * 100f / (float) file.getTotalSpace();
}

public boolean isSharedFs(CoreDescriptor cd) {
try (SolrCore core = this.getCore(cd.getName())) {
if (core != null) {
Expand Down