Skip to content

Switch to the directory of the clone before beginning the test#2119

Merged
dsmiley merged 1 commit into
apache:mainfrom
uvatbc:main
Dec 5, 2023
Merged

Switch to the directory of the clone before beginning the test#2119
dsmiley merged 1 commit into
apache:mainfrom
uvatbc:main

Conversation

@uvatbc
Copy link
Copy Markdown
Contributor

@uvatbc uvatbc commented Dec 5, 2023

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

The crave tests need to be run from the location of the clone, not the default start directory.

Solution

Change the directory to the appropriate one.

Tests

Have not been able to test this locally, but the creation of this pull request should result in it being tested.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@dsmiley
Copy link
Copy Markdown
Contributor

dsmiley commented Dec 5, 2023

Notwistanding the one test that failed, are the results good to you @uvatbc ?

@uvatbc
Copy link
Copy Markdown
Contributor Author

uvatbc commented Dec 5, 2023

Notwistanding the one test that failed, are the results good to you @uvatbc ?

Yes. The most important part was that the directory of execution was /crave-devspaces/pipeline/runs/7105372116_3656/solr
See: https://foss.crave.io/app/#/build/info/74271?team=5

The one where it wasn't right was:https://foss.crave.io/app/#/build/info/74270?team=5 /crave-devspaces/actions-runner1/_work/solr/solr

@dsmiley dsmiley merged commit 3dbca2f into apache:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants