SOLR-15484: use latest version of bouncycastle libraries#2145
Merged
Conversation
- newer version of bouncycastle dependencies - old version did not parse dates correctly for some locales
- fix version files and checksums
asfgit
pushed a commit
that referenced
this pull request
Dec 12, 2023
Contributor
|
I get a gradle warning that the NOTICE file is not in use. I believe it is required only for ASL and BSD licenses, not for MIT. I don't think it hurts to keep it around though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a new failure for
JWTAuthPluginIntegrationTest[1] because the version of BouncyCastle we are using parses dates using the default locale. (seeorg.bouncycastle.asn1.x509.Time) This is fixed with the latest version (bc*-jdk15on:1.70>bc*-jdk18on:1.77). This I believe puts us on a newer version than what is used byMockOAuth2Serverbut best I can tell there are no other usages. I think this will be a harmless upgrade.[1] https://jenkins.thetaphi.de/job/Solr-main-Linux/15897/testReport/junit/org.apache.solr.security.jwt/JWTAuthPluginIntegrationTest/classMethod/