Clarify the docs about the Package Manager#2147
Merged
Merged
Conversation
epugh
requested changes
Dec 12, 2023
| Versions are sorted by their numeric value and the highest is the latest. | ||
| Versions are sorted by their values in lexicographic order, and the largest string is considered to be the latest. | ||
|
|
||
| CAUTION: Lexicographic order for version strings means that for a package with versions *1.2.0*, *1.9.0*, *1.11.0*, |
Contributor
There was a problem hiding this comment.
REally? Can we please get a JIRA to fix this ;-).
| The default version used in any collection is always the latest. | ||
| However, setting a per-collection property in `params.json` ensures that the versions are always fixed irrespective of the new versions added. | ||
| However, setting a per-collection property in `params.json` ensures that the collection uses the same | ||
| package version (i.e., version *2.0*), irrespective of any versions larger than *2.0* that may be added to Solr |
Contributor
There was a problem hiding this comment.
I wonder if we should say "later" or "more recent" than, versus "larger"
Contributor
Author
There was a problem hiding this comment.
@epugh I thought of that, but felt that it could be misleading - because, for example, the current package version in Solr could be 2.11.0, and then the user uploads 2.9.0 (which isn't more recent semantically, but is "larger" lexicographically).
So without the params.json, the collection will be "upgraded" to use 2.9.0, - but if the version 2.11.0 is pinned, it will be used regardless of how the Solr compares the version strings.
mkhludnev
pushed a commit
to mkhludnev/solr
that referenced
this pull request
Dec 12, 2023
Co-authored-by: Andrey Bozhko <abozhko@apple.com>
mkhludnev
added a commit
that referenced
this pull request
Dec 12, 2023
mkhludnev
added a commit
that referenced
this pull request
Dec 13, 2023
mkhludnev
added a commit
that referenced
this pull request
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Reference Guide to clarify the actual behavior of Package Manager, - specifically, how it processes the version strings of packages.
Tests
NA
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.