SOLR-15525: Read ZK credentials from a file specified using a system property instead of exposing plain-text credentials#222
Merged
thelabdude merged 4 commits intoapache:mainfrom Jul 16, 2021
Conversation
…property instead of exposing plain-text credentials
HoustonPutman
approved these changes
Jul 15, 2021
Contributor
HoustonPutman
left a comment
There was a problem hiding this comment.
Clean and Simple 👍
madrob
reviewed
Jul 15, 2021
solr/core/src/test/org/apache/solr/cloud/VMParamsZkACLAndCredentialsProvidersTest.java
Outdated
Show resolved
Hide resolved
…ntialsProvidersTest.java Co-authored-by: Mike Drob <mdrob@apache.org>
Contributor
|
Yea but I didn’t test it 😅 |
Contributor
Author
|
@madrob ~ forbidden check didn't like your suggested change: It looks like it wants a FileWriter like I had originally. |
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
…property instead of exposing plain-text credentials (apache#222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15525
Description
Added new Java system property
zkDigestCredentialsFileto allow loading of zk creds from a file instead of from system properties.Tests
Added to existing unit test
VMParamsZkACLAndCredentialsProvidersTestto use the newzkDigestCredentialsFilefeature.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.