factor out SolrIndexSearcher.populateScoresIfNeeded method#2280
Merged
cpoerschke merged 1 commit intoapache:mainfrom Feb 20, 2024
Merged
Conversation
dsmiley
approved these changes
Feb 19, 2024
asfgit
pushed a commit
that referenced
this pull request
Feb 20, 2024
(cherry picked from commit 065d21a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactoring, noticed whilst code reading on #2248 pull request. No JIRA or CHANGES.txt entry needed here IMHO.
The refactoring also makes it easier to see that there is what appears to be an inconsistency on the two code paths w.r.t. score mode and hits relation -- that might benefit from further investigation and perhaps changes-with-test-coverage to make the two code paths consistent but I'd consider that to be outside the scope of this pull request i.e. this here is a like-for-like refactoring only. WDYT?