Add correct exception logging in the ExecutorUtil#2384
Merged
HoustonPutman merged 1 commit intoapache:mainfrom Apr 16, 2024
Merged
Add correct exception logging in the ExecutorUtil#2384HoustonPutman merged 1 commit intoapache:mainfrom
HoustonPutman merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
An example of how this would fix exception logging: Existing implementation: Fix: Notice how the cause-submitter-stacktrace ordering is now correct, and that the downstream error is actually being reported as the ultimate cause. This will also work even if the error/exception has its own causes. |
Contributor
|
This took me a bit of experimenting with locally, but I understand what's going on now and agree that the new ordering is correct. Thanks for cleaning this up @HoustonPutman! |
madrob
reviewed
Apr 1, 2024
| if (t instanceof OutOfMemoryError) { | ||
| throw t; | ||
| } | ||
| if (enableSubmitterStackTrace) { |
Contributor
There was a problem hiding this comment.
Don't we still need to have this flag?
Contributor
Author
There was a problem hiding this comment.
I don't believe so. So the baseCause, which is now always logged, will be t (the real throwable) if submitterStackTrace is null. Since when enableSumbitterStackTrace==false then submitterStackTrace=null (logic from above), then we will only be logging t if enableSubmitterStackTrace==false. The submitterStackTraces will only be included if enableSubmitterStackTrace==true.
It is still a little different than the previous logic, which only logged the error message, but I think the spirit of the flag is still the same.
HoustonPutman
added a commit
that referenced
this pull request
Apr 16, 2024
(cherry picked from commit 07606c7)
tboeghk
pushed a commit
to otto-de/solr
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually logs the correct stack trace for an exception caught in the ExecutorUtil.
It also provides the correct ordering of "causes" unlike the way it was previously implemented, where the "cause" was actually the thread that called the Executor. Now the "cause" is the error in the executor, and the base exception is the thread that called the ExecutorUtil.
It may look strange that we always use an
Exceptionclass, but this is ok since these exceptions that we are copying are only made a few lines up and are always of classException. (They aren't real exceptions, they are merely storing the stackTrace of how the original thread called the Executor, or the tree of executor calls). Therefore, no information is being lost here.