Skip to content

SOLR-15579: Re-configure calcite to allow more values in an IN clause#249

Merged
thelabdude merged 9 commits intoapache:mainfrom
thelabdude:SOLR-15579
Aug 12, 2021
Merged

SOLR-15579: Re-configure calcite to allow more values in an IN clause#249
thelabdude merged 9 commits intoapache:mainfrom
thelabdude:SOLR-15579

Conversation

@thelabdude
Copy link
Contributor

@thelabdude thelabdude commented Aug 6, 2021

https://issues.apache.org/jira/browse/SOLR-15579

Description

See the JIRA

Solution

Override the default DEFAULT_IN_SUB_QUERY_THRESHOLD for Calcite's SqlToRelConverter to allow more values in an IN clause. Previously using more than 19 would result in the IN clause being ignored, now users are only limited by the maxBooleanClauses configured for a collection.

Tests

Unit test with 200 values in an IN clause. Also cleaned up the NOT + AND/OR query construction logic.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant