SOLR-15579: Re-configure calcite to allow more values in an IN clause#249
Merged
thelabdude merged 9 commits intoapache:mainfrom Aug 12, 2021
Merged
SOLR-15579: Re-configure calcite to allow more values in an IN clause#249thelabdude merged 9 commits intoapache:mainfrom
thelabdude merged 9 commits intoapache:mainfrom
Conversation
…tiveQuery flag from Translator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15579
Description
See the JIRA
Solution
Override the default
DEFAULT_IN_SUB_QUERY_THRESHOLDfor Calcite'sSqlToRelConverterto allow more values in an IN clause. Previously using more than 19 would result in the IN clause being ignored, now users are only limited by themaxBooleanClausesconfigured for a collection.Tests
Unit test with 200 values in an IN clause. Also cleaned up the NOT + AND/OR query construction logic.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.