Delegate Collection Property Management to CollectionPropertiesZkStateReader#2584
Closed
aparnasuresh85 wants to merge 2 commits into
Closed
Delegate Collection Property Management to CollectionPropertiesZkStateReader#2584aparnasuresh85 wants to merge 2 commits into
aparnasuresh85 wants to merge 2 commits into
Conversation
dsmiley
reviewed
Jul 23, 2024
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
I'm concerned you copied this from our fork of Solr, and thus it's not a strict refactor. I suggest producing this PR very mechanically via a series of IntelliJ IDE driven refactorings to minimize human error. Then force push a replacement. I try to do IDE driven refactorings for coding I do; IntelliJ has always excelled at this.
| } | ||
|
|
||
| private void notifyCloudCollectionsListeners(boolean notifyIfSame) { | ||
| if (cloudCollectionsListeners.isEmpty()) { |
Contributor
There was a problem hiding this comment.
this is not a pure refactor
| * changes. | ||
| */ | ||
| public void registerCloudCollectionsListener(CloudCollectionsListener cloudCollectionsListener) { | ||
| if (cloudCollectionsListeners.isEmpty()) { |
Contributor
There was a problem hiding this comment.
this is not a pure refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
https://issues.apache.org/jira/browse/SOLR-XXXXX
Description
Summary
This PR introduces
CollectionPropertiesZkStateReaderto manage collection property methods, shifting these responsibilities fromZkStateReader.Purpose
ZkStateReaderis currently overloaded with tasks, including refreshing and maintaining state for live nodes, collections, cluster state, collection properties, replica properties, aliases, and more. By distributing these responsibilities into specialized classes, we can ensure that each class has a single, well-defined responsibility, thereby reducing complexity.This PR aims to transfer collection property management to
CollectionPropertiesZkStateReader.ZkStateReader's API remains unchanged, ensuring backward compatibility.Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Ensured all existing tests pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.