SOLR-13138: remove deprecated LegacyBM25SimilarityFactory#274
Merged
cpoerschke merged 7 commits intoapache:mainfrom Sep 29, 2021
Merged
Conversation
…Similarity-remove Resolved Conflicts: solr/core/src/java/org/apache/solr/search/similarities/BM25SimilarityFactory.java solr/core/src/java/org/apache/solr/search/similarities/LegacyBM25SimilarityFactory.java solr/solr-ref-guide/src/schema-elements.adoc
janhoy
reviewed
Aug 29, 2021
Contributor
janhoy
left a comment
janhoy
left a comment
There was a problem hiding this comment.
LGTM, after a quick review. Have not had chance to compile or do thorough review, look for other mentions etc, so feel free to commit if you feel confident enough. Or else I’ll give it another view next week.
Contributor
Author
Will proceed to merge next then. And as always, happy to action any post-commit review feedback. |
janhoy
pushed a commit
to cominvent/solr
that referenced
this pull request
Sep 29, 2021
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solr/mainandlucene-solr/branch_8xto be merged first.solr/mainonly.https://issues.apache.org/jira/browse/SOLR-13138