SOLR-17456: TransactionLog ctor integrity#2762
Merged
dsmiley merged 1 commit intoapache:mainfrom Nov 4, 2024
Merged
Conversation
The TransactionLog constructor can't handle an existing file being present; it shouldn't be there. Should throw an exception in this case, NOT log a warning, leaving the object in a partially constructed state.
dsmiley
commented
Oct 14, 2024
|
|
||
| success = true; | ||
|
|
||
| assert ObjectReleaseTracker.track(this); |
Contributor
Author
There was a problem hiding this comment.
In addition to the scope of the PR, I did a little move of this line to the bottom where it's supposed to be.
Contributor
Author
|
I'm going to merge this in a couple days without further review. It's a super simple one. |
dsmiley
added a commit
that referenced
this pull request
Nov 4, 2024
The TransactionLog constructor can't handle an existing file being present; it shouldn't be there. Should throw an exception in this case, NOT log a warning which would leave the object in a partially constructed state. This should happen in the first place, of course. I see no evidence it has occurred. (cherry picked from commit e849fd0)
tboeghk
pushed a commit
to otto-de/solr
that referenced
this pull request
Feb 18, 2026
The TransactionLog constructor can't handle an existing file being present; it shouldn't be there. Should throw an exception in this case, NOT log a warning which would leave the object in a partially constructed state. This should happen in the first place, of course. I see no evidence it has occurred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TransactionLog constructor can't handle an existing file being present; it shouldn't be there. Should throw an exception in this case, NOT log a warning, leaving the object in a partially constructed state.
https://issues.apache.org/jira/browse/SOLR-17456
BTW I experienced this on a fork of Solr and I don't know the root cause. Since applying the fix in this PR, I have not seen it since (perhaps by chance). It should never happen!
Not sure if needs CHANGES.txt