SOLR-17530: Prometheus regex cloud pattern fix for core names#2795
Merged
dsmiley merged 4 commits intoapache:mainfrom Nov 2, 2024
Merged
SOLR-17530: Prometheus regex cloud pattern fix for core names#2795dsmiley merged 4 commits intoapache:mainfrom
dsmiley merged 4 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@dsmiley mind taking a look at this? Oversight on my part for the core regex pattern. |
dsmiley
approved these changes
Oct 28, 2024
Contributor
|
Thanks; an easy fix. |
tboeghk
pushed a commit
to otto-de/solr
that referenced
this pull request
Feb 18, 2026
…eplicas (apache#2795) The new Prometheus response writer wasn't detecting TLOG or PULL replicas properly. --------- Co-authored-by: David Smiley <dsmiley@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17530
Description
The regex pattern for Solr cloud mode assumed all core names ended with a
replica_n[0-9]+which is incorrect. Some core names should be able to have any single character letter before the numbers.Solution
Change regex pattern to with
.instead ofnto match any single characterTests
testCloudCorePatternandtestBadCloudCorePatternto test the regex cloud pattern.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.