SOLR-17321: Update ecj compiler versions to JDK 17#2804
Merged
malliaridis merged 2 commits intoapache:mainfrom Nov 5, 2024
Merged
SOLR-17321: Update ecj compiler versions to JDK 17#2804malliaridis merged 2 commits intoapache:mainfrom
malliaridis merged 2 commits intoapache:mainfrom
Conversation
This was referenced Oct 30, 2024
Closed
Contributor
|
Just pushed to yours! It would be cool to get it to java 21 for the non-solrj/api modules. But this is a good first step! |
HoustonPutman
approved these changes
Nov 5, 2024
tboeghk
pushed a commit
to otto-de/solr
that referenced
this pull request
Feb 18, 2026
* Increase ecj version, fix one issue found --------- Co-authored-by: Houston Putman <houston@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17321
Description
With the JDK upgrade we can bump the JDT compiler versions as well. This allows us to use language features that were introduced after Java 11 (like switch expressions, text blocks, pattern matching of
instanceofand more) without ECJ complaining.I am linking these PRs to the Jira issue because they are related to the JDK changes.
Solution
This PR changes the JDT compiler configuration to Java 17 (because some of our modules targeting 17+).
Tests
No tests were modified.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.