forbidden-apis: Don't need java.solr.txt file #2866
Conversation
| "**.SuppressForbidden" | ||
| ] | ||
|
|
||
| doFirst dynamicSignatures.curry(configurations.toolsCompileClasspath, "lucene") |
There was a problem hiding this comment.
I don't quite understand this line but the reference to "lucene" probably matches nothing.
| ] | ||
| } | ||
|
|
||
| // Configure solr-specific rules. |
There was a problem hiding this comment.
the whole configuration overall is for Solr
| // Configure solr-specific rules. | ||
| if (prj.path.startsWith(":solr")) { | ||
| forbiddenApisMain { | ||
| doFirst dynamicSignatures.curry(configurations.compileClasspath, "solr") |
There was a problem hiding this comment.
Maybe I should have kept this line? I'm not sure what it accomplishes.
| } | ||
|
|
||
| forbiddenApisTest { | ||
| doFirst dynamicSignatures.curry(configurations.testCompileClasspath, "solr") |
There was a problem hiding this comment.
Maybe I should have kept this line? I'm not sure what it accomplishes.
|
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
|
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
1 participant
I was looking through our forbidden-apis configuration, and I see "java.solr.txt" file that appears named this way because it was added at a time when Lucene & Solr co-existed and needed to be differentiated. I moved the rules from there into "defaults.all.txt", and I removed the reference to this file in forbidden-apis.gradle.
But I see other stuff in forbidden-apis.gradle that I don't understand; it's a rather complicated gradle file IMO. Hoping for your review @dweiss as you wrote this one.