SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests#2893
Merged
epugh merged 5 commits intoapache:mainfrom Dec 14, 2024
Merged
SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests#2893epugh merged 5 commits intoapache:mainfrom
epugh merged 5 commits intoapache:mainfrom
Conversation
Typos, some dead methods and dead variables.
malliaridis
reviewed
Dec 6, 2024
Contributor
malliaridis
left a comment
malliaridis
left a comment
There was a problem hiding this comment.
I am not sure if it is fine to remove the public static final field LOCAL_ACTIVITY_DURING_REPLICATION, but besides that, everything else looks fine.
The assertion was a great finding though.
dsmiley
reviewed
Dec 17, 2024
Comment on lines
+1522
to
1524
| // data | ||
| // loss | ||
| // don't commit on leader version zero for PULL replicas as PULL should only get its index |
Contributor
Author
There was a problem hiding this comment.
dang it, I trusted gw tidy too much..
| Other Changes | ||
| --------------------- | ||
| (No changes) | ||
| * SOLR-17579: Remove unused code and other refactorings in ReplicationHandler and tests. Removed unused public |
Contributor
There was a problem hiding this comment.
honestly, would any reader of CHANGES.txt care? I'm not questioning your effort in this PR but ...
Contributor
Author
There was a problem hiding this comment.
i went back and forth on it, since I'd created a JIRA... I then thought, it should then go in Changes... Plus removing a public variable...
We do need to add to our dev docs a concise "this is what Changes" is for...
tboeghk
pushed a commit
to otto-de/solr
that referenced
this pull request
Feb 18, 2026
…sts (apache#2893) * Refactoring suggested by IDE. * Typos, some dead methods and dead variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typos, some dead methods and dead variables.
https://issues.apache.org/jira/browse/SOLR-17579
Description
Intellij suggested some fixes.
Solution
Do them and run tests
Tests
existing