Skip to content

Remove unused variable#29

Merged
erikhatcher merged 2 commits intoapache:mainfrom
erikhatcher:GraphExpressionTest-cleanup
Mar 18, 2021
Merged

Remove unused variable#29
erikhatcher merged 2 commits intoapache:mainfrom
erikhatcher:GraphExpressionTest-cleanup

Conversation

@erikhatcher
Copy link
Contributor

@erikhatcher erikhatcher commented Mar 18, 2021

Description

The params variable is unused, duplicating the fq that is inside the expression already.

Solution

Removed the unused variable.

Tests

This is a test :)

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@erikhatcher erikhatcher merged commit 680059e into apache:main Mar 18, 2021
@erikhatcher
Copy link
Contributor Author

Thanks, @epugh for the quick thumbs-up. Here's to my first Solr TLP commit not breaking the build :)

@erikhatcher erikhatcher deleted the GraphExpressionTest-cleanup branch March 18, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments