Skip to content

Fix rarely flaky DeleteInactiveReplicaTest.#3012

Merged
psalagnac merged 1 commit intoapache:mainfrom
psalagnac:flaky-test
Jan 9, 2025
Merged

Fix rarely flaky DeleteInactiveReplicaTest.#3012
psalagnac merged 1 commit intoapache:mainfrom
psalagnac:flaky-test

Conversation

@psalagnac
Copy link
Contributor

Description

The test was retrieving a replica from cluster state using core name instead of correct replica name.
The test is rarely failing because of this, it may happen.

Solution

Fix the test, just replace getCoreName() by getName().

The test was retrieving a replica from cluster state using core name
instead of correct replica name.
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@psalagnac psalagnac merged commit 1c2b649 into apache:main Jan 9, 2025
2 of 3 checks passed
@psalagnac psalagnac deleted the flaky-test branch January 9, 2025 21:47
psalagnac added a commit that referenced this pull request Jan 9, 2025
The test was retrieving a replica from cluster state using core name
instead of correct replica name.
tboeghk pushed a commit to otto-de/solr that referenced this pull request Feb 18, 2026
The test was retrieving a replica from cluster state using core name
instead of correct replica name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments