SOLR-15658: First pass of testing with findify/s3mock#314
Closed
HoustonPutman wants to merge 1 commit intoapache:mainfrom
Closed
SOLR-15658: First pass of testing with findify/s3mock#314HoustonPutman wants to merge 1 commit intoapache:mainfrom
HoustonPutman wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
I'm a little worried that findify/s3mock hasn't been updated in >3 years now. Might be worth looking at something else... |
Contributor
Author
|
Fair enough, good point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15658
Still very much a work in progress.
There are two tests that will fail consistently:
S3BackupRepositoryTest.testCanListFullOrEmptyDirectoriesS3IncrementalBackupTest.testBackupIncrementalThe rest of the tests are either the same speed or much faster than using adobe/S3Mock, except for the following which take 30s each, for no discernible reason:
S3BackupRepositoryTest.testBackwardRandomAccessS3BackupRepositoryTest.testCopyFilesS3BackupRepositoryTest.testRandomAccessInputThis s3Mock also requires that directory paths end in
/for all operations including reads, which AWS S3 does not require. Some code had to be changed for this.I still also need to remove the Old S3 Mock from the codebase.