SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…#316
Merged
markrmiller merged 1 commit intoapache:mainfrom Oct 7, 2021
Merged
SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…#316markrmiller merged 1 commit intoapache:mainfrom
markrmiller merged 1 commit intoapache:mainfrom
Conversation
markrmiller
force-pushed
the
SOLR-15659
branch
from
e5bf88c to
d4cdd69
Compare
Member
Author
|
ObjectReleaseTracker is not in the test framework code and those methods moved to SolrTestCase reference a carrot test framework class, so I removed that the timeout and retries that I should have removed vs just setting to 0 anyway. |
markrmiller
force-pushed
the
SOLR-15659
branch
2 times, most recently
from
01b5455 to
bb0b4e8
Compare
madrob
approved these changes
Oct 7, 2021
Contributor
There was a problem hiding this comment.
Feels like this method should be renamed since it is doing more than just the logger now.
Member
Author
There was a problem hiding this comment.
Yeah, I've renamed it like 20 times at this point :) One more time for old times sake.
markrmiller
force-pushed
the
SOLR-15659
branch
2 times, most recently
from
ae94d8b to
7ee50d1
Compare
…ave no grace time.
markrmiller
force-pushed
the
SOLR-15659
branch
from
7ee50d1 to
ec28526
Compare
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
…ave no grace time. (apache#316)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15659