build solr/webapp/build.gradle: remove needless excludes#3180
Merged
dsmiley merged 1 commit intoapache:mainfrom Feb 13, 2025
Merged
build solr/webapp/build.gradle: remove needless excludes#3180dsmiley merged 1 commit intoapache:mainfrom
dsmiley merged 1 commit intoapache:mainfrom
Conversation
These exclusions don't match anything.
epugh
approved these changes
Feb 12, 2025
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
I suppose if the build still works, then LGTM!
Contributor
|
Yeah, I guess the non-minimized files used to be in source control? |
malliaridis
approved these changes
Feb 13, 2025
Contributor
malliaridis
left a comment
malliaridis
left a comment
There was a problem hiding this comment.
Yep, looked up the history and we had at some point a move to minimized files, but probably forgot to remove these exclusions.
dsmiley
added a commit
that referenced
this pull request
Feb 13, 2025
These exclusions don't match anything. (cherry picked from commit d7c6565)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These exclusions don't match anything.