SOLR-8362: proposal for polyField docValues support for TextField#321
Closed
magibney wants to merge 17 commits intoapache:mainfrom
Closed
SOLR-8362: proposal for polyField docValues support for TextField#321magibney wants to merge 17 commits intoapache:mainfrom
magibney wants to merge 17 commits intoapache:mainfrom
Conversation
The purpose of this commit is to record the local (normally uncommitted) changes to support development against a local lucene snapshot. In addition to the changes recorded in this commit, a system property change is called for, which may be achieved by specifying `-DluceneSnapshot` on the command line, or (particularly useful when gradle is not invoked directly -- e.g., for IDE development), by adding the following to `gradle.properties` file: # Uncomment below if developing against a local lucene snapshot systemProp.luceneSnapshot
This reverts commit 74117e4. As a consequence of the decision to not move forward with merging LUCENE-10023, we pull analysis in support of tokenized docValues into Solr, and no longer need to rely on a Lucene SNAPSHOT version
This reverts commit d64b980.
Contributor
Author
|
note: precommit will fail due to nocommits, but existing and new tests all should pass. |
Contributor
Author
|
For anyone curious about this PR at a high level, the refguide additions might be a good place to start: |
…62-text-field-docvalues
|
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution! |
|
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: SOLR-8362
Cotinuation of: apache/lucene-solr#1691
This PR introduces docValues support for TextField, supporting
The rationale behind this PR is essentially the same as laid out in this comment. The main difference in this PR (as opposed to apache/lucene-solr#1691 described in that comment) is that this PR abandons the hope for Lucene-native support for post-analysis docValues (see LUCENE-10023) and instead generates post-analysis docValues by "pre-analyzing" (at the cost of duplicate effort) in
TextField.createFields(...).Lots of relevant context can also be found at: SOLR-11917.