SOLR-17682: Rename BinaryResponseWriter to JavaBinResponseWriter#3267
Merged
dsmiley merged 1 commit intoMar 20, 2025
Merged
Conversation
Contributor
Author
|
I'll merge in a couple days. |
gerlowskija
approved these changes
Mar 20, 2025
Contributor
gerlowskija
left a comment
gerlowskija
left a comment
There was a problem hiding this comment.
Love it; the old name always bothered me, and making it more specific will avoid confusing folks now that we have two binary formats (javabin fully, CBOR partially)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17682
2nd PR for this JIRA; I wanted to do this separately.