SOLR-15678 Allow only known content types in ShowFileRequestHandler#336
Merged
janhoy merged 7 commits intoapache:mainfrom Oct 11, 2021
Merged
SOLR-15678 Allow only known content types in ShowFileRequestHandler#336janhoy merged 7 commits intoapache:mainfrom
janhoy merged 7 commits intoapache:mainfrom
Conversation
Add tests for default detection as well as prove that path traversal is unsuccessful
Add tests for default detection as well as prove that path traversal is unsuccessful
# Conflicts: # solr/CHANGES.txt
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15678
Also now requires "config-read" permission in order to use the "Files" sub-menu in UI, since you here can read all config.
I also updated ref-guide wording around 'config-read' permission to include "Files Screen" and "Configset API".