SOLR-15685: Add Devcontainer to make building easier#339
Closed
TheSench wants to merge 2 commits into
Closed
Conversation
This allows developers to start up the project inside a Docker container and run the build without needing to install any build tools to their machine. This .devcontainer was generated by selecting the standard Perl image, and then updating the Dockerfile to also install JDK 11.
Contributor
Author
|
Not sure what the proper way to proceed is regarding the license in the |
|
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15685
Description
This PR adds a
.devcontainer, which provides a Docker Perl/JDK11 build environment. This can be used for new/infrequent contributors to quickly get up and running without needing to install any build tools.Solution
Using VSCode's Remote Development extension to add the
Perl.devcontainer(includes Perl 5). I then updated the auto-generatedDockerfileto include the Java 11 JDK. With these changes, I am able to assemble Solr inside a Docker container without needing to install any other build tools on my machine.Tests
I started up the container and ran
gradlew assembleinside of it. Once the build finished, I ran the generatedbin/solrto verify that Solr was able to start.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.N/AI have added tests for my changes.