Skip to content

SOLR-17938: Switch to maven central for getting the cuVS artifacts #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

SOLR-17938: Switch to maven central for getting the cuVS artifacts #3844

merged 2 commits into from
Nov 7, 2025

Conversation

@narangvivek10
Copy link
Contributor

@narangvivek10 narangvivek10 commented Nov 6, 2025

@github-actions github-actions bot added dependencies Dependency upgrades tool:build labels Nov 6, 2025
@narangvivek10 narangvivek10 mentioned this pull request Nov 6, 2025
Closed
@narangvivek10 narangvivek10 marked this pull request as ready for review November 6, 2025 22:31
@narangvivek10
Copy link
Contributor Author

narangvivek10 commented Nov 6, 2025

I notice that the validate changelog check has failed in this run. I think it would be appropriate to add a no-changelog label to this PR (I cannot, as I think I am not authorized to), as I think this is just reverting something that was a temporary measure and not significant enough to go into changelog.

@janhoy
Copy link
Contributor

janhoy commented Nov 7, 2025

Hi. You can also ignore it.

Sorry for making that check yell so loud when there are legitimate PRs that don’t need a changelog. And the fact that only committers can add labels makes the label solution a bit cumbersome. Suggestions for improvement welcome. One idea is for the action to add a PR comment for missing changelog yml and still pass the check.

@narangvivek10
Copy link
Contributor Author

narangvivek10 commented Nov 7, 2025

Can someone please re-run the pipeline (as I do not have the authority to) after its last failed run? Thanks!

@chatman chatman merged commit 92aff63 into apache:main Nov 7, 2025
3 of 4 checks passed
@chatman chatman deleted the vivek/SOLR-17938-switch-to-maven-central-for-getting-the-cuVS-artifacts branch November 7, 2025 17:53
@narangvivek10
Copy link
Contributor Author

narangvivek10 commented Nov 8, 2025

Suggestions for improvement welcome

Hey @janhoy I was curious and going through the setup and noticed this in the validate-changelog.yml and was wondering if it is still needed after this commit?

@janhoy
Copy link
Contributor

janhoy commented Nov 8, 2025

You’re right, that check can be removed

@narangvivek10
Copy link
Contributor Author

narangvivek10 commented Nov 8, 2025

You’re right, that check can be removed

Great, I will create a Jira ticket and link a PR for this. Thanks!

@narangvivek10
Copy link
Contributor Author

narangvivek10 commented Nov 8, 2025

You’re right, that check can be removed

I have created a task on Jira and a PR for this. Thanks!

@dsmiley dsmiley mentioned this pull request Nov 9, 2025
Merged
dsmiley pushed a commit that referenced this pull request Nov 9, 2025
@narangvivek10 @dsmiley
SOLR-17938: Switch to maven central for getting the cuVS artifacts (#…
c39300b 
…3844)

* Removes SearchScale maven repository reference and update checksum

(cherry picked from commit 92aff63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janhoy janhoy janhoy approved these changes

Assignees

No one assigned

Labels

dependencies Dependency upgrades no-changelog tool:build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narangvivek10 @janhoy @chatman