SOLR-17985: Speed up no-rows distributed queries #3849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
reviewed
Nov 10, 2025
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
How might this be tested? Is it observable / non-invasive?
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
Outdated
Show resolved
Hide resolved
Contributor
Author
So I can test that Solr isn't collecting scores when rows=0. But I can't necessarily test that it's using the exact right Collector , however the fact that Solr isn't collecting scores really does kind of tell us it is the correct collector... But I guess it does make sure this exact change is correct. If we don't ask for scores, scores will not be collected. |
dsmiley
approved these changes
Nov 10, 2025
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
thanks for the test; good enough for me.
HoustonPutman
added a commit
that referenced
this pull request
Nov 11, 2025
(cherry picked from commit a72691c)
HoustonPutman
added a commit
that referenced
this pull request
Nov 11, 2025
(cherry picked from commit a72691c)
HoustonPutman
added a commit
that referenced
this pull request
Nov 11, 2025
(cherry picked from commit a72691c)
HoustonPutman
added a commit
that referenced
this pull request
Nov 11, 2025
(cherry picked from commit a72691c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17985