SOLR-15760: Improve the default distributed facet overrequest function/heuristic#385
SOLR-15760: Improve the default distributed facet overrequest function/heuristic#385magibney wants to merge 1 commit intoapache:mainfrom
Conversation
…n/heuristic For logical consistency, distributed facet overrequest should make no distinction between offset and limit; instead, distributed overrequest should be calculated as a function of the sum of offset+limit, boosting relatively heavily when few values are requested, and decaying asymptotically to `f(x)=x` for larger numbers of requested values.
|
The condition on small offset was added in 1f77776, and I think in a pinch this could stand to simply be removed (to restore the initial unconditional linear overrequest boost according to the overrequest function *EDIT: I misidentified the initial introduction of the @dsmiley, could you take a quick look at this? I think there's some sense to the assertion that larger numbers of requested values actually need less overrequest (though I still don't think the distinction between offset and limit is relevant). Intuitively I'd also think that perhaps we'd want to boost extremely low gross-limit requests by more than 4 (the proposal currently in this PR has a floor of 12 for shard requests). Ultimately I think there a three options that might make sense:
|
|
I like it -- especially treating offset+limit the same as limit, and for monotonically increasing the over request to a point. but I'm not the ideal reviewer. @yonik , @joel-bernstein and @hossman come to mind. |
|
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution! |
|
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
|
WDYT of re-opening & merging this one @magibney ? Seems straight-forward change. |
See: SOLR-15760
For logical consistency, distributed facet overrequest should make no distinction between offset and limit; instead, distributed overrequest should be calculated as a function of the sum of offset+limit, boosting relatively heavily when few values are requested, and decaying asymptotically to
f(x)=xfor larger numbers of requested values.