Conversation
| LOG4J_CONFIG=() | ||
| if [ -n "$LOG4J_PROPS" ]; then | ||
| LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_PROPS") | ||
| LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_PROPS -Dlog4j2.is.webapp=false -Dlog4j2.garbagefreeThreadContextMap=true -Dlog4j2.enableDirectEncoders=true -Dlog4j2.enable.threadlocals=true") |
There was a problem hiding this comment.
Can you add a comment with a link to some docs or anything else explaining where these properties come from and how we found them? I'm trying to search for them and coming up short. Maybe I'll dive into log4j code base next, although I'd like to avoid that if I can.
There was a problem hiding this comment.
details in jira here: https://issues.apache.org/jira/browse/SOLR-15477
malliaridis
left a comment
malliaridis
left a comment
There was a problem hiding this comment.
With the recent changes in the CLI scripts, I believe we could update this one and get it merged?
For my understanding, is the configuration -Dlog4j2.is.webapp=false ok also in case of our webapp? Or do we have to set it to true for the webapp explicitly?
| @@ -1973,7 +1973,7 @@ fi | |||
|
|
|||
| LOG4J_CONFIG=() | |||
There was a problem hiding this comment.
If the log4j options should always be loaded as default, we should consider adding them here instead, since the LOG4J_PROPS is only populated in examples where a custom log4j2.xml configuration is mandatory.
4 participants
https://issues.apache.org/jira/browse/SOLR-15477