SOLR-18104: Remove deprecated constructor in SnapShooter#4137
Open
epugh wants to merge 3 commits intoapache:mainfrom
Open
SOLR-18104: Remove deprecated constructor in SnapShooter#4137epugh wants to merge 3 commits intoapache:mainfrom
epugh wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
the
documentation
Contributor
Author
|
Tests pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18104
Description
This PR is just abut removing a old constructor for SnapShooter that doesn't take in a repo (and therefore internally assumes LocalFileSystemRepository. Basically, when we added the concept of Repository we only modified the code halfway, leaving this method with a deprecation tag.
I THOUGHT this was going to be about removing snapshooter... But alas, it isn't.
Solution
Modify ReplicationHandler to call SnapShooter propertly.
I noticed taht some parameters are reference that are NOT documented in Ref Guide..
Tests
existing tests