Skip to content

JettySolrRunner: catch TimeoutException from Jetty 12 graceful shutdown#4220

Merged
dsmiley merged 1 commit intoapache:mainfrom
dsmiley:JettySolrRunner_TimeoutException
Mar 18, 2026
Merged

JettySolrRunner: catch TimeoutException from Jetty 12 graceful shutdown#4220
dsmiley merged 1 commit intoapache:mainfrom
dsmiley:JettySolrRunner_TimeoutException

Conversation

@dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Mar 17, 2026

Jetty 12's Server.doStop() throws TimeoutException when graceful shutdown exceeds the 15-second stop timeout. This was propagating uncaught, skipping all forceful cleanup (qtp stop, rte stop, server join), causing thread leaks and cascading test failures like LB2SolrClientTest flakiness on CI.

https://develocity.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=solr-root&search.timeZoneId=America%2FNew_York&tests.container=org.apache.solr.client.solrj.impl.LB2SolrClientTest&tests.test=testTwoServers

Jetty 12's Server.doStop() throws TimeoutException when graceful
shutdown exceeds the 15-second stop timeout. This was propagating
uncaught, skipping all forceful cleanup (qtp stop, rte stop,
server join), causing thread leaks and cascading test failures
like LB2SolrClientTest flakiness on CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dsmiley
Copy link
Contributor Author

dsmiley commented Mar 17, 2026

Planning to merge this in a day or so. The description/analysis was written by Claude Opus. The change seems innocent. It's only a test matter.

@dsmiley dsmiley merged commit 5bbf003 into apache:main Mar 18, 2026
4 of 5 checks passed
@dsmiley dsmiley deleted the JettySolrRunner_TimeoutException branch March 18, 2026 00:17
dsmiley added a commit that referenced this pull request Mar 20, 2026
…wn (#4220)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant