Add clean to cherrypick.sh before runnign (precommit) check#4238
Merged
janhoy merged 1 commit intoapache:mainfrom Mar 26, 2026
Merged
Add clean to cherrypick.sh before runnign (precommit) check#4238janhoy merged 1 commit intoapache:mainfrom
janhoy merged 1 commit intoapache:mainfrom
Conversation
epugh
approved these changes
Mar 25, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
I don't use the script everytime, but I do anytime it's more then the most minor change, and so this makes sense even if it makes things take longer! Cause I am using it for a more meaty backport.
HoustonPutman
approved these changes
Mar 25, 2026
Contributor
Author
|
Thanks, now I'll use the updated script to backport itself :) |
janhoy
added a commit
that referenced
this pull request
Mar 26, 2026
(cherry picked from commit ec51d13)
janhoy
added a commit
that referenced
this pull request
Mar 26, 2026
(cherry picked from commit ec51d13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If not doing this, old build directories on disk may cause false test failures, such as detecting broken links in old stale javadoc, which is not a problem if re-built.
I had a cherry pick abort with below message, but turned out it was checking stale javadoc...