SOLR-18082: Add jersey BOM to align versions of all jersey dependencies#4244
SOLR-18082: Add jersey BOM to align versions of all jersey dependencies#4244malliaridis wants to merge 2 commits intoapache:mainfrom
Conversation
8f0b51c to
67a24a7
Compare
epugh
left a comment
There was a problem hiding this comment.
This all makes sense to me, but I don't have a great handle on how gradle dependencies get managed.
Looks like this would get us to "everything matching jersey 3.1.11"?
| jayway-jsonpath = "2.9.0" | ||
| jctools = "4.0.5" | ||
| jersey = "3.1.11" | ||
| # TODO Sync with jersey versions |
67a24a7 to
30a3c07
Compare
@epugh Exactly. A bill of materials (BOM), if added correctly to a module (that is with that However, following this route makes it mandatory to always include the BOM together with the dependencies that do not define a version in the I will check for any related jira issues to update the PR with a ticket number, and check the POM files to confirm it resolves everything correctly before merging it. |
https://issues.apache.org/jira/browse/SOLR-18082
Description
jersey provides a bill of materials that can be used to align all jersey dependencies and manage their versions via the BOM. Right now the only dependency
org.glassfish.jersey.containers:jersey-container-jetty-httpis out-of-sync due to development history of the jersey modules.Solution
This PR introduces the jersey BOM, adds it to the only module (
:solr:core) that includes the jersey dependencies in thedependenciesblock and removes the existing versions of jersey to align them via the BOM.Tests
No tests were added or altered.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.