Tests don't need to reference the Servlet API, mostly.#4265
Merged
Conversation
Just a refactoring. Simplified RestTestBase; no functional change. No caller customized extraServlets or stopAtShutdown
github-actions
Bot
added
documentation
javadocs
epugh
reviewed
Apr 6, 2026
| setupTestInit(solrconfig, schema, false); | ||
| System.setProperty("solr.index.updatelog.enabled", "false"); | ||
|
|
||
| createJettyAndHarness(tmpSolrHome, solrconfig, schema, "/solr", true, null); |
Contributor
There was a problem hiding this comment.
nice to see those remaining /solr dealt with.
epugh
approved these changes
Apr 6, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
LGTM. I've gotten very confused in all the variations in createJettyAndHarness and this looks great.
dsmiley
added a commit
that referenced
this pull request
Apr 11, 2026
And simplified RestTestBase; no functional change. No caller customized extraServlets or stopAtShutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a refactoring.
Simplified RestTestBase; no functional change. No caller customized extraServlets or stopAtShutdown