Skip to content

Upgrade Kotlin ecosystem: Kotlin 2.3.20, ktor 3.4.2, kotlinx-browser 0.5.0, kotlinx-serialization 1.11.0#4316

Closed
janhoy wants to merge 22 commits intoapache:mainfrom
janhoy:kotlin-ecosystem-upgrade
Closed

Upgrade Kotlin ecosystem: Kotlin 2.3.20, ktor 3.4.2, kotlinx-browser 0.5.0, kotlinx-serialization 1.11.0#4316
janhoy wants to merge 22 commits intoapache:mainfrom
janhoy:kotlin-ecosystem-upgrade

Conversation

@janhoy
Copy link
Copy Markdown
Contributor

@janhoy janhoy commented Apr 21, 2026

Summary

Combined upgrade of all interdependent Kotlin/WasmJs ecosystem libraries in one branch to resolve cascading compatibility issues between the individual renovate PRs:

These libraries have inter-dependencies (Kotlin version affects ktor WasmJs compilation, serialization affects Compose resources generation, etc.) so combining them into a single branch makes it easier to stabilize.

Known issues to iterate on

  • WasmJs build failures (kotlinWasmStoreYarnLock, compileKotlinWasmJs, compileTestDevelopmentExecutableKotlinWasmJs) need investigation once CI runs
  • UI lockfile updated manually (WASM toolchain not available locally); CI may reveal additional lockfile issues

Test plan

  • gradle check passes (especially spotlessKotlinCheck, kotlinWasmStoreYarnLock, compileKotlinWasmJs)
  • Run SolrJ Tests passes
  • extraction module tests with docker passes

…ckfile

- Reverted io.nlopez.compose.rules:ktlint 0.5.7 -> 0.4.27: v0.5.7 has
  a bug where standard:annotation-spacing throws exceptions on all Kotlin
  files; no fixed version is available yet (PR apache#3893 deferred)
- Updated kotlin-js-store/wasm/yarn.lock via kotlinWasmUpgradeYarnLock
  to reflect Kotlin 2.3.20 + ktor 3.4.2 dependency changes
- Regenerated solr/ui/gradle.lockfile for Kotlin 2.3.20 + new deps
@janhoy janhoy requested a review from malliaridis April 21, 2026 23:04
janhoy added 3 commits April 22, 2026 01:07
…grade

# Conflicts:
#	gradle/libs.versions.toml
#	solr/modules/jwt-auth/gradle.lockfile
#	solr/ui/gradle.lockfile
@janhoy janhoy changed the title Upgrade Kotlin ecosystem: Kotlin 2.3.20, ktor 3.4.2, kotlinx-browser 0.5.0, kotlinx-serialization 1.11.0, ktlint 0.5.7 Upgrade Kotlin ecosystem: Kotlin 2.3.20, ktor 3.4.2, kotlinx-browser 0.5.0, kotlinx-serialization 1.11.0 Apr 23, 2026
@janhoy
Copy link
Copy Markdown
Contributor Author

janhoy commented Apr 23, 2026

Some few test failures, believe they are not related

ERROR: The following test(s) have failed:
  - org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:5DFC11A967A9B8C4]} (:solr:core)
    Test history: https://develocity.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.cloud.api.collections.CollectionReloadTest&tests.test=testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:5DFC11A967A9B8C4]} http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:5DFC11A967A9B8C4]}
    Test output: /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.api.collections.CollectionReloadTest.txt
    Reproduce with: ./gradlew :solr:core:test --tests "org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:5DFC11A967A9B8C4]}" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=A7EB6BB7E0825511 -Ptests.timeoutSuite=600000! -Ptests.useSecurityManager=true -Ptests.file.encoding=ISO-8859-1

  - org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:E9AAAD55536B73E8]} (:solr:core)
    Test history: https://develocity.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.cloud.api.collections.CollectionReloadTest&tests.test=testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:E9AAAD55536B73E8]} http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:E9AAAD55536B73E8]}
    Test output: /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.api.collections.CollectionReloadTest.txt
    Reproduce with: ./gradlew :solr:core:test --tests "org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeletePull {seed=[A7EB6BB7E0825511:E9AAAD55536B73E8]}" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=A7EB6BB7E0825511 -Ptests.timeoutSuite=600000! -Ptests.useSecurityManager=true -Ptests.file.encoding=ISO-8859-1

  - org.apache.solr.handler.component.CombinedQuerySolrCloudTest.testQueriesWithFacetAndHighlightsCollapse (:solr:core)
    Test history: https://develocity.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.handler.component.CombinedQuerySolrCloudTest&tests.test=testQueriesWithFacetAndHighlightsCollapse http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.handler.component.CombinedQuerySolrCloudTest.testQueriesWithFacetAndHighlightsCollapse
    Test output: /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.handler.component.CombinedQuerySolrCloudTest.txt
    Reproduce with: ./gradlew :solr:core:test --tests "org.apache.solr.handler.component.CombinedQuerySolrCloudTest.testQueriesWithFacetAndHighlightsCollapse" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=A7EB6BB7E0825511 -Ptests.timeoutSuite=600000! -Ptests.useSecurityManager=true -Ptests.file.encoding=ISO-8859-1

@janhoy
Copy link
Copy Markdown
Contributor Author

janhoy commented Apr 23, 2026

I found #4283 Which has a high overlap with this PR.
@malliaridis I believe your PR is wider and covers more, so I'll let you land it first, probably rendering this void.

@janhoy janhoy marked this pull request as draft April 23, 2026 07:10
@malliaridis
Copy link
Copy Markdown
Contributor

Thanks for adding me as reviewer and sorry for replying so late. Yes, the PR is addressing a couple dependency updates, I also included a few updates from this PR that I did not include before. I will soon merge them. :)

@malliaridis
Copy link
Copy Markdown
Contributor

I think this can be closed by now, as #4283 was merged.

Backporting to 10.x would require some prior dependency updates to be backported as well. Should I leave it for now until we plan the next 10.x release?

@janhoy janhoy closed this Apr 23, 2026
@janhoy
Copy link
Copy Markdown
Contributor Author

janhoy commented Apr 23, 2026

Yea, I have focused on main branch with all deps, so there is a lot to be back ported.

Turned out there were basically 4 commits that needed backporting to branch_10x. Just did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants