Skip to content

NO-JIRA: Flaky test fix testDistributedQueryDoesNotReadFromZk #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlbiscoc wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

NO-JIRA: Flaky test fix testDistributedQueryDoesNotReadFromZk #4429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,12 @@ public void testDistributedQueryDoesNotReadFromZk() throws Exception {
CollectionAdminRequest.createCollection(secondColl, "conf", 1, 1)
.setCreateNodeSet(jettys.get(0).getNodeName())
.processAndWait(cluster.getSolrClient(), DEFAULT_TIMEOUT);
cluster

// Wait on node 1's ZkStateReader (not the cluster client's) to check for ready state
JettySolrRunner nodeWithoutSecondColl = jettys.get(1);
Copy link
Copy Markdown
Contributor

@dsmiley dsmiley May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this var name. Maybe node 0 should have a similar var name we can use like "nodeWithBothColls". Just an idea.

nodeWithoutSecondColl
.getCoreContainer()
.getZkController()
.getZkStateReader()
.waitForState(
secondColl,
Expand All @@ -735,7 +740,6 @@ public void testDistributedQueryDoesNotReadFromZk() throws Exception {
try {
// Node 1 hosts COLLECTION but not secondColl.
// Send a multi-collection query to trigger LazyCollectionRef get call
JettySolrRunner nodeWithoutSecondColl = jettys.get(1);
try (SolrClient client =
new HttpJettySolrClient.Builder(nodeWithoutSecondColl.getBaseUrl().toString()).build()) {

Expand Down
Loading