Fix non-atomic write in ShardBackupMetadata.store() that can destroy backup metadata#4444
Open
markrmiller wants to merge 1 commit into
Open
Fix non-atomic write in ShardBackupMetadata.store() that can destroy backup metadata#4444markrmiller wants to merge 1 commit into
markrmiller wants to merge 1 commit into
Conversation
…metadata The store() method deleted the existing metadata file before writing the replacement. If the write failed (disk full, network error, crash), both old and new metadata were lost, making the backup point permanently unrestorable. Removed the delete-before-write and rely on createOutput to overwrite, so the old file persists if the new write fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18249
The store() method deletes the existing metadata file before writing the replacement. If the write fails (disk full, network error, crash), both old and new metadata are lost, making the backup point permanently unrestorable. Removes the delete-before-write and relies on createOutput to overwrite, so the old file persists if the new write fails.